Fix flakiness with WipeMyCal test#5454
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hariombalhara
commented
Nov 10, 2022
|
|
||
| const $openBookingCount = await page.locator('[data-testid="bookings"] > *').count(); | ||
| await expect($openBookingCount).toBe(3); | ||
| expect($openBookingCount).toBe(3); |
Member
Author
There was a problem hiding this comment.
expect doesn't return promise here
hariombalhara
commented
Nov 10, 2022
| const $openBookings = await page.locator('[data-testid="bookings"]'); | ||
| // Don't await send_request click, otherwise mutation can possibly occur before observer is attached | ||
| page.locator("data-testid=send_request").click(); | ||
| const $openBookings = page.locator('[data-testid="bookings"]'); |
Member
Author
There was a problem hiding this comment.
page.locator() doesnt return promise
hariombalhara
added
♻️ autoupdate
JeroenReumkens
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample failure here https://github.com/calcom/cal.com/actions/runs/3430008728/jobs/5716404026