Skip to content

Save meeting url to metadata of bookings and add it to webhook payload#5773

Merged
kodiakhq[bot] merged 31 commits intomainfrom
feat/save-meeting-url
Dec 15, 2022
Merged

Save meeting url to metadata of bookings and add it to webhook payload#5773
kodiakhq[bot] merged 31 commits intomainfrom
feat/save-meeting-url

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Adds new metadata column to booking model to save the meeting URL. Also adds the meeting URL to webhook payload.

Webhook payload for booking created and rescheduled:

With Cal Video link:
Screenshot 2022-11-29 at 14 54 32

With Google Meet link:
Screenshot 2022-11-29 at 14 55 23

Fixes #5518

Environment: Staging(main branch)

How should this be tested?

  • Book an event type with a video call app as a location (Cal Video, Google Meet, Zoom, ...)
  • Check database if videoCallUrl is saved in metadata
  • Created a webhook and test if it returns the video call data when it is triggered

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 9:45PM (UTC)

@alishaz-polymath alishaz-polymath added the docs area: docs, documentation, cal.com/docs label Dec 1, 2022
@zomars
Copy link
Copy Markdown
Contributor

zomars commented Dec 8, 2022

@CarinaWolli we need to update the test snapshot:
image

@CarinaWolli
Copy link
Copy Markdown
Member Author

@CarinaWolli we need to update the test snapshot:

@zomars I have updated them, but they are still failing. I compared the actual and expected test result file and they look identical to me. Do you know how to fix that?

@zomars
Copy link
Copy Markdown
Contributor

zomars commented Dec 12, 2022

@CarinaWolli we need to update the test snapshot:

@zomars I have updated them, but they are still failing. I compared the actual and expected test result file and they look identical to me. Do you know how to fix that?

Run test with yarn e2e -u and commit the updated file

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

Comment thread apps/web/playwright/webhook.e2e.ts Outdated
Comment thread apps/web/playwright/webhook.e2e.ts Outdated
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved conflicts and ready to go

LGTM

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 15, 2022
@kodiakhq kodiakhq Bot merged commit 6885419 into main Dec 15, 2022
@kodiakhq kodiakhq Bot deleted the feat/save-meeting-url branch December 15, 2022 21:43
@alishaz-polymath alishaz-polymath removed the docs area: docs, documentation, cal.com/docs label Jan 29, 2023
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only ❗️ migrations contains migration files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-498] Include video location in web hooks

4 participants