Skip to content

Feature/Embed/Add Embed ui instruction config to hide event type description#5951

Merged
kodiakhq[bot] merged 4 commits intomainfrom
5792-cal-529-hide-event-type-details-in-embed
Dec 13, 2022
Merged

Feature/Embed/Add Embed ui instruction config to hide event type description#5951
kodiakhq[bot] merged 4 commits intomainfrom
5792-cal-529-hide-event-type-details-in-embed

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Dec 9, 2022

What does this PR do?

Fixes #5792

Demo Loom

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • See Loom

Checklist

@linear
Copy link
Copy Markdown

linear Bot commented Dec 9, 2022

CAL-529 Hide event type details in embed

Hi! We are looking for a way to embed the Cal.Com's calendar to our website without event type details.

Expected behaviour would be embedding the calendar widget only, without event name, host's name, location or duration.

This is important for us for a smoother experience on mobile - 95% of our traffic is mobile :)

We used to use the Hide event details option in Calendly - I'll attach a screenshot, might be useful

m


Tagging @alishaz-polymath and @hariom as we discussed this on a call today :)

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Dec 13, 2022 at 7:16AM (UTC)

@hariombalhara hariombalhara changed the title Add embed ui instruction to hide event type description Feature/Embed/Add Embed ui instruction config to hide event type description Dec 9, 2022
@hariombalhara hariombalhara force-pushed the 5792-cal-529-hide-event-type-details-in-embed branch from c63a46b to 4b3516d Compare December 9, 2022 15:47
@hariombalhara hariombalhara added the docs area: docs, documentation, cal.com/docs label Dec 9, 2022
@hariombalhara hariombalhara requested a review from a team December 9, 2022 15:55
@hariombalhara hariombalhara marked this pull request as ready for review December 9, 2022 15:55
@hariombalhara hariombalhara force-pushed the 5792-cal-529-hide-event-type-details-in-embed branch from 4b3516d to daff63f Compare December 9, 2022 15:58
@hariombalhara
Copy link
Copy Markdown
Member Author

@Jaibles FYI, This is a new toggle in Embed. Please check the loom. Being a very small change, I think designs are not required.

@hariombalhara hariombalhara self-assigned this Dec 9, 2022
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Review done

{embed.title}
</h3>
<hr className={classNames("mt-4", embedType === "element-click" ? "hidden" : "")} />
<div className="max-h-97 flex flex-col overflow-y-auto">
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BugFix: On big screens, this was unnecessarily restricting the view like this
Screenshot 2022-12-09 at 6 07 57 PM

<div className="text-sm">Embed Window Sizing</div>
<div className="justify-left flex items-center">
<TextField
name="width"
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BugFix: This was adding the labels with values the same as name unnecessarily.
Screenshot 2022-12-09 at 6 09 54 PM

theme: Theme.auto,
floatingPopup: {},
elementClick: {},
hideEventTypeDetails: false,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default keep it disabled.

<div>
<main
className={classNames(
"flex-col md:mx-4 lg:flex",
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-12-09 at 6 26 32 PM

BugFix: Should have been flex for all screen sizes. See, the bug in screenshot without flex.

</div> -->
</div>
<h2>Inline Embed Examples</h2>
<div id="namespaces-test">
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following is some cleanup on Embed Playground page to keep it clean.

);
}

if (only === "all" || only === "hideEventTypeDetails") {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hideEventTypeDetails demo in playground

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 13, 2022
@kodiakhq kodiakhq Bot merged commit 3a641e0 into main Dec 13, 2022
@kodiakhq kodiakhq Bot deleted the 5792-cal-529-hide-event-type-details-in-embed branch December 13, 2022 07:23
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
@alishaz-polymath alishaz-polymath removed the docs area: docs, documentation, cal.com/docs label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-529] Hide event type details in embed

4 participants