Skip to content

fix: hidden content due to teams upgrade banner#5968

Merged
PeerRich merged 1 commit intocalcom:mainfrom
G3root:fix-banner
Dec 10, 2022
Merged

fix: hidden content due to teams upgrade banner#5968
PeerRich merged 1 commit intocalcom:mainfrom
G3root:fix-banner

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Dec 10, 2022

What does this PR do?

before:
https://www.loom.com/share/8dba8192180e4628bcca786ff82813de

after:
https://www.loom.com/share/2ea1e06733894944aef2f52cdf281992

fixes: #6030

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 10, 2022

@G3root is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@PeerRich PeerRich enabled auto-merge (squash) December 10, 2022 21:45
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 10, 2022
@PeerRich PeerRich merged commit 5850d22 into calcom:main Dec 10, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 9:56PM (UTC)

@Udit-takkar
Copy link
Copy Markdown
Contributor

hey @G3root we want #5718 top banner to cover the entire app width ( other than settings which has sidebar)

@G3root
Copy link
Copy Markdown
Contributor Author

G3root commented Dec 12, 2022

hey @G3root we want #5718 top banner to cover the entire app width ( other than settings which has sidebar)

@Udit-takkar my bad , didn't know It should cover the entire app. But the problem persisted in the app layout also.

@PeerRich
Copy link
Copy Markdown
Member

@Udit-takkar wanna reopen this?

@Udit-takkar
Copy link
Copy Markdown
Contributor

me and @JeroenReumkens are already looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-594] Banner causing the navigation menu to shift down and hide the user info

3 participants