Hotfix/Hide Branding in Embed.#5975
Merged
JeroenReumkens merged 2 commits intomainfrom Dec 12, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
commented
Dec 12, 2022
| </div> | ||
| {(!restProps.isBrandingHidden || isEmbed) && <PoweredByCal />} | ||
| {/* FIXME: We don't show branding in Embed yet because we need to place branding on top of the main content. Keeping it outside the main content would have visibility issues because outside main content background is transparent */} | ||
| {!restProps.isBrandingHidden && !isEmbed && <PoweredByCal />} |
Member
Author
There was a problem hiding this comment.
We haven't shown branding in embed since the beginning. Some recent changes made it visible in Embed.
I have now added a comment also explaining why branding isn't shown in Embed as of now.
Member
Author
There was a problem hiding this comment.
cc @Jaibles for design on appropriate placement of branding(Powered by Cal) on embeds
JeroenReumkens
approved these changes
Dec 12, 2022
hariombalhara
added a commit
that referenced
this pull request
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5973
Environment: Production
Type of change