Skip to content

Outlook - list all calendars#6004

Merged
pumfleet merged 5 commits intomainfrom
outlook-calendar-handle-pagination
Dec 14, 2022
Merged

Outlook - list all calendars#6004
pumfleet merged 5 commits intomainfrom
outlook-calendar-handle-pagination

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

@joeauyeung joeauyeung commented Dec 13, 2022

What does this PR do?

This PR aims to handle paginated MS Graph calls to list all calendars. Currently the limit is 10 calendars per call so we need to fetch the next 10.

Fixes #6007

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • On Outlook create 10 calendars
  • Install Outlook to your Cal instance
  • On the install calendar page, all calendars should be listed

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 11:15AM (UTC)

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we add a test for this?

Copy link
Copy Markdown
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pumfleet pumfleet merged commit 2078f12 into main Dec 14, 2022
@pumfleet pumfleet deleted the outlook-calendar-handle-pagination branch December 14, 2022 11:04
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-588] Outlook, handle paginated calendar query

4 participants