Skip to content

Fixes for testing workflow action#6005

Merged
kodiakhq[bot] merged 8 commits intomainfrom
fix/test-workflow-action
Dec 15, 2022
Merged

Fixes for testing workflow action#6005
kodiakhq[bot] merged 8 commits intomainfrom
fix/test-workflow-action

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Fixes # (issue)

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 8:45PM (UTC)

if (isSMSAction(step.action)) {
const hasTeamPlan = (await ctx.prisma.membership.count({ where: { userId: user.id } })) > 0;
if (!hasTeamPlan) {
throw new TRPCError({ code: "UNAUTHORIZED", message: "Team plan needed" });
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only allow users on teams plan to test SMS actions

Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@CarinaWolli CarinaWolli enabled auto-merge (squash) December 15, 2022 08:14
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 15, 2022
@zomars zomars disabled auto-merge December 15, 2022 20:35
@kodiakhq kodiakhq Bot merged commit 20402ac into main Dec 15, 2022
@kodiakhq kodiakhq Bot deleted the fix/test-workflow-action branch December 15, 2022 20:48
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants