Skip to content

removed z-index from topbanner#6008

Merged
PeerRich merged 2 commits intomainfrom
5772-cal-497-top-banner-is-behind-command-k-menu
Dec 13, 2022
Merged

removed z-index from topbanner#6008
PeerRich merged 2 commits intomainfrom
5772-cal-497-top-banner-is-behind-command-k-menu

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Dec 13, 2022

turns out we dont need a z-index for the top banner because the parent already has one

this way, the KBar dialog looks correct

fixes #5772

@PeerRich PeerRich linked an issue Dec 13, 2022 that may be closed by this pull request
@linear
Copy link
Copy Markdown

linear Bot commented Dec 13, 2022

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Dec 13, 2022 at 4:16PM (UTC)

@PeerRich PeerRich requested a review from Udit-takkar December 13, 2022 16:09
@PeerRich PeerRich enabled auto-merge (squash) December 13, 2022 16:09
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 13, 2022
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@PeerRich PeerRich merged commit 8849d11 into main Dec 13, 2022
@PeerRich PeerRich deleted the 5772-cal-497-top-banner-is-behind-command-k-menu branch December 13, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-497] Top banner is behind command K menu

2 participants