added layout for empty month to go to the next month#6011
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "disable_app": "Disable App", | ||
| "disable_app_description": "Disabling this app could cause problems with how your users interact with Cal", | ||
| "edit_keys": "Edit Keys", | ||
| "apps_description": "Enable apps for your instance of Cal", |
There was a problem hiding this comment.
there was a duplicate string introduced previously
| return ( | ||
| <> | ||
| <Meta title={t("apps")} description={t("apps_description")} /> | ||
| <Meta title={t("apps")} description={t("admin_apps_description")} /> |
There was a problem hiding this comment.
there was a duplicate string introduced previously
…ce' of https://github.com/calcom/cal.com into 5799-cal-508-public-booking-show-no-times-in-month-notice
PeerRich
added
♻️ autoupdate
| month: string | null; | ||
| nextMonthButton: () => void; |
There was a problem hiding this comment.
there are probably better types for this
| month: string | null; | ||
| nextMonthButton: (newMonth: number) => void; |
There was a problem hiding this comment.
there are probably better types for this
| </div> | ||
| ))} | ||
|
|
||
| {!props.isLoading && includedDates && includedDates?.length === 0 && ( |
There was a problem hiding this comment.
there is a very short flicker like 0.1ms on first load. maybe there is another prop we can check for here
| month={month} | ||
| nextMonthButton={() => changeMonth(+1)} |
There was a problem hiding this comment.
we need these two props for the overlay. preferably we move the component out of <Days> and do all the calculation on the backend to speed up the frontend.
it should be:
{isNotAvailable ? <NoAvailabilityOverlay/> : <Days/>}
There was a problem hiding this comment.
On the other hand this would make this UI fairly difficult, as both Days and the overlay are being drawn.
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
I like it, couldn't reproduce the flicker on my end by the way. Works great!
PeerRich
deleted the
5799-cal-508-public-booking-show-no-times-in-month-notice
branch
2 participants
fixes #5799
TODO