Skip to content

fix: remove duplicate meta component in two-factor-auth page#6124

Merged
PeerRich merged 1 commit intocalcom:mainfrom
G3root:fix-two-factor-title
Dec 20, 2022
Merged

fix: remove duplicate meta component in two-factor-auth page#6124
PeerRich merged 1 commit intocalcom:mainfrom
G3root:fix-two-factor-title

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Dec 20, 2022

What does this PR do?

Fixes this warning:
Warning: A title element received an array with more than 1 element as children. In browsers title Elements can only have Text Nodes as children. If the children being rendered output more than a single text node in aggregate the browser will display markup and comments as text in the title and hydration will likely fail and fall back to client rendering

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2022

@G3root is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@PeerRich PeerRich enabled auto-merge (squash) December 20, 2022 15:13
@PeerRich PeerRich merged commit dcf0fad into calcom:main Dec 20, 2022
@G3root G3root deleted the fix-two-factor-title branch December 20, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants