Skip to content

[Hotfix] Fixing direct link encoding#6131

Merged
zomars merged 5 commits intomainfrom
fix/direct-link-with-slashes
Dec 20, 2022
Merged

[Hotfix] Fixing direct link encoding#6131
zomars merged 5 commits intomainfrom
fix/direct-link-with-slashes

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Dec 20, 2022

What does this PR do?

For some reason Vercel decodes a URL so %2F in a purposefully encoded URL becomes / which breaks direct links. This behavior does not happen locally. Solution relies on base64url where the + and / characters of standard Base64 are respectively replaced by - and _.

Fixes #6086

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@leog leog requested a review from a team December 20, 2022 19:47
@leog leog self-assigned this Dec 20, 2022
@leog leog changed the title Fixing direct link encoding [Hotfix] Fixing direct link encoding Dec 20, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 11:06PM (UTC)

Comment thread apps/web/pages/booking/direct/[...link].tsx
@leog leog requested a review from zomars December 20, 2022 20:11
@leog leog enabled auto-merge (squash) December 20, 2022 22:55
@leog leog added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Dec 20, 2022
@zomars zomars merged commit 7a6349b into main Dec 20, 2022
@zomars zomars deleted the fix/direct-link-with-slashes branch December 20, 2022 23:00
leog added a commit that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-616] Time zone and encoding issues on direct link accept/reject page

3 participants