Skip to content

fixes available times overflow bug on safari#6208

Merged
PeerRich merged 8 commits intocalcom:mainfrom
phishy:6201-fixes-safari-overflow
Jan 3, 2023
Merged

fixes available times overflow bug on safari#6208
PeerRich merged 8 commits intocalcom:mainfrom
phishy:6201-fixes-safari-overflow

Conversation

@phishy
Copy link
Copy Markdown
Contributor

@phishy phishy commented Dec 28, 2022

What does this PR do?

Fixes overflow bug on Safari, where there was too much space between available times.

Fixes #6201

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Make an event type with a duration of 90 minutes
  • Load in mobile Safari or desktop safari in really small window
  • Notice that the space between available times is back to normal

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 28, 2022

@phishy is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-02 at 9 02 45 PM

Although this solves the spacing issue but size of last slot is vary small in mobile version
and in desktop version there is no scrollbar so i can't see all slots

@phishy
Copy link
Copy Markdown
Contributor Author

phishy commented Jan 3, 2023

@Udit-takkar and now?

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 11:13AM (UTC)

@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jan 3, 2023

tested, seems to work. waiting for @Udit-takkar's re-review

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 It works fine now. just one thing grid-cols-1 and gap-x-2 aren't necessary now as you have removed grid.

@phishy
Copy link
Copy Markdown
Contributor Author

phishy commented Jan 3, 2023

🙏 It works fine now. just one thing grid-cols-1 and gap-x-2 aren't necessary now as you have removed grid.

Ah yeah. I thought I had removed grid-cols-1. Nice catch on gap-x-2. I'll push it now.

@PeerRich PeerRich enabled auto-merge (squash) January 3, 2023 21:53
@PeerRich PeerRich merged commit 9250b20 into calcom:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too big extra space between timeslots on mobile safari

3 participants