Skip to content

Show admin password top banner#6226

Merged
kodiakhq[bot] merged 2 commits intomainfrom
feat/admin-password-notifcation
Jan 1, 2023
Merged

Show admin password top banner#6226
kodiakhq[bot] merged 2 commits intomainfrom
feat/admin-password-notifcation

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

Adds top banner error if you are admin but do not have the right password length

Admin with correct password length:
CleanShot 2022-12-31 at 12 57 16@2x

ADMIN without valid password:
CleanShot 2022-12-31 at 13 01 48@2x

Normal User:
CleanShot 2022-12-31 at 13 02 26@2x

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 31, 2022 at 1:15PM (UTC)

@github-actions github-actions Bot added automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date labels Dec 31, 2022
belongsToActiveTeam?: boolean;
username?: PrismaUser["username"];
role?: PrismaUser["role"];
role?: PrismaUser["role"] | "INACTIVE_ADMIN";
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need this on a database level only on a session obj

Comment on lines 159 to +161
<TeamsUpgradeBanner />
<ImpersonatingBanner />
<AdminPasswordBanner />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not important but what happens if you have multiple banners?

@kodiakhq kodiakhq Bot merged commit 6548f01 into main Jan 1, 2023
@kodiakhq kodiakhq Bot deleted the feat/admin-password-notifcation branch January 1, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants