Skip to content

Fix lang and dir attributes not being set#6243

Merged
PeerRich merged 1 commit intomainfrom
fix/lang-dir
Jan 3, 2023
Merged

Fix lang and dir attributes not being set#6243
PeerRich merged 1 commit intomainfrom
fix/lang-dir

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jan 3, 2023

What does this PR do?

Fixes #6237

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 7:57AM (UTC)

Comment thread packages/lib/i18n.ts
return preferredLocale ?? i18n.defaultLocale;
}

export const getOrSetUserLocaleFromHeaders = async (req: IncomingMessage): Promise<string> => {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't being used anywhere

Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! that works! 👏

@PeerRich PeerRich merged commit 2a1acc1 into main Jan 3, 2023
@PeerRich PeerRich deleted the fix/lang-dir branch January 3, 2023 10:09
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-667] update lang="" in <html> when changing language

2 participants