Move Apps to ui/components#6245
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ShellSubHeading, | ||
| showToast, | ||
| SkeletonLoader, | ||
| AppSkeletonLoader as SkeletonLoader, |
There was a problem hiding this comment.
See comment in PR description
| import { AppFrontendPayload as App } from "@calcom/types/App"; | ||
|
|
||
| export const _SBApps: App[] = [ |
There was a problem hiding this comment.
Mock data - can be ignored and is only used in stories
| import { Canvas, Meta, Story, ArgsTable } from '@storybook/addon-docs'; | ||
| import { Examples, Example, Note, Title,CustomArgsTable, VariantRow,VariantsTable} from '@calcom/storybook/components' | ||
| import { Icon } from "@calcom/ui/Icon"; | ||
| import { Icon } from "@calcom/ui"; |
There was a problem hiding this comment.
Icon is breaking stories when directly imported - speaking to @JeroenReumkens this has been fixed in a PR he is working on
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
looks good, tho merge conflicts
JeroenReumkens
left a comment
JeroenReumkens
left a comment
There was a problem hiding this comment.
@sean-brydon Looks good, one small question remaining.
| import { HOSTED_CAL_FEATURES } from "@calcom/lib/constants"; | ||
| import { trpc } from "@calcom/trpc/react"; | ||
| import { getSettingsLayout as getLayout, SkeletonLoader } from "@calcom/ui"; | ||
| // TODO(Sean): Figure out why this is using AppSkeletonLoader |
There was a problem hiding this comment.
Is this a todo we still need to do, or is this before you realised it was actually used quite often throughout the rest of the app? In that case we can delete this todo I think. Might be a good idea to create an issue to check all AppSkeletonUsage and see if we have to replace it with a real skeleton (I think we should).
PeerRich
added
♻️ autoupdate
3 participants
Part of cleaning up V2 folder.
Moves apps from v2 into ui/components folder.
More stories will be added when we move to SB V7 - allows us to use next link easily supporting AppCard that uses
useRoutercurrently its a bit of a pain#6244 was created on the back of this PR. While moving files about i realised a lot of the skeleton loaders acrossed the app are using the skeleton loader dedicated for app store :thisisfine: