Skip to content

Chor/v2 UI tidy - Dialog & Toasts#6307

Merged
PeerRich merged 6 commits intomainfrom
chor/v2-ui-tidy
Jan 9, 2023
Merged

Chor/v2 UI tidy - Dialog & Toasts#6307
PeerRich merged 6 commits intomainfrom
chor/v2-ui-tidy

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

Tidies up Dialog and Toasts moves from v2 into ui/components

Few changes to toasts - extracted each variant into a component so we can demo it in storybook

  • Created storybook file for toasts

CleanShot 2023-01-06 at 11 33 09@2x

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 9, 2023 at 1:55PM (UTC)


import { showToast } from ".";
import { Dialog, DialogClose, DialogContent, DialogFooter } from "../ui/v2";
import { Dialog, DialogClose, DialogContent, DialogFooter, showToast } from "@calcom/ui";
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File moved to features so we can import from calcom/ui

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars
Copy link
Copy Markdown
Contributor

zomars commented Jan 6, 2023

Let's check tests and fix conflicts tho

@sean-brydon sean-brydon added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Jan 9, 2023
@PeerRich PeerRich merged commit 112d504 into main Jan 9, 2023
@PeerRich PeerRich deleted the chor/v2-ui-tidy branch January 9, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants