Skip to content

Fix/Next.js-13/Circular Dependency in Routing Forms#6321

Merged
PeerRich merged 4 commits intomainfrom
fix/next13/circular-dep-routing-forms
Jan 7, 2023
Merged

Fix/Next.js-13/Circular Dependency in Routing Forms#6321
PeerRich merged 4 commits intomainfrom
fix/next13/circular-dep-routing-forms

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jan 7, 2023

What does this PR do?

Before:
image

Also, fixes an unstable test.

The issue comes only in the dev environment and is caused by an update to Next.js 13. Next.js-13's import related optimizations seem to be the cause of it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 7, 2023 at 3:46PM (UTC)

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Jan 7, 2023
@hariombalhara hariombalhara requested a review from a team January 7, 2023 15:03
@hariombalhara hariombalhara force-pushed the fix/next13/circular-dep-routing-forms branch from 6f7a602 to d67ee6c Compare January 7, 2023 15:04
@github-actions github-actions Bot removed automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date labels Jan 7, 2023
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jan 7, 2023

tested, works!

@PeerRich PeerRich enabled auto-merge (squash) January 7, 2023 15:37
@PeerRich PeerRich merged commit 364e187 into main Jan 7, 2023
@PeerRich PeerRich deleted the fix/next13/circular-dep-routing-forms branch January 7, 2023 15:50
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants