Skip to content

set useQueryParam to false for app categories#6330

Merged
emrysal merged 4 commits intomainfrom
hotfix/fix-app-category-navigation
Jan 7, 2023
Merged

set useQueryParam to false for app categories#6330
emrysal merged 4 commits intomainfrom
hotfix/fix-app-category-navigation

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jan 7, 2023

What does this PR do?

See subject.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 7, 2023 at 11:25PM (UTC)

@emrysal emrysal marked this pull request as ready for review January 7, 2023 23:08
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Jan 7, 2023
@emrysal
Copy link
Copy Markdown
Contributor Author

emrysal commented Jan 7, 2023

Back in PR - it's used in three places (1) the admin settings, without query param (2) the admin setup, with query param (3) the installed apps, without query param also. Addressed all cases.

@PeerRich PeerRich removed ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Jan 7, 2023
@emrysal emrysal merged commit 1ad6bba into main Jan 7, 2023
@emrysal emrysal deleted the hotfix/fix-app-category-navigation branch January 7, 2023 23:21
emrysal added a commit that referenced this pull request Jan 7, 2023
* set useQueryParam to false for app categories

* New param 'useQueryParam' for AppCategoryNavigation/AdminAppsList

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
emrysal added a commit that referenced this pull request Jan 7, 2023
* set useQueryParam to false for app categories

* New param 'useQueryParam' for AppCategoryNavigation/AdminAppsList

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants