Skip to content

fix: fixme line in todo action#6982

Merged
emrysal merged 2 commits intomainfrom
fix-todo-action
Feb 13, 2023
Merged

fix: fixme line in todo action#6982
emrysal merged 2 commits intomainfrom
fix-todo-action

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Feb 9, 2023

What does this PR do?

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@G3root G3root requested a review from zomars February 9, 2023 18:13
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 2:20AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Feb 10, 2023 at 2:20AM (UTC)

Comment thread .github/workflows/todo-to-issue.yml Outdated
@@ -1,7 +1,6 @@
name: TODO to Issue
on:
push:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the line 1 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed the changes

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never @zomars 🤣

@emrysal emrysal merged commit f04c634 into main Feb 13, 2023
@emrysal emrysal deleted the fix-todo-action branch February 13, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants