[CAL-1030] fix flickering border issue in menu layout for mobile#7036
[CAL-1030] fix flickering border issue in menu layout for mobile#7036PeerRich merged 4 commits intocalcom:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@amirfakhrullah is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
@amirfakhrullah try to use DropdownItem inside DropdownMenuItem if possible just like it is used in other parts of codebase |
|
@Udit-takkar I just changed it. I can confirm that all pages/sections that use the Screen.Recording.2023-02-11.at.1.56.42.PM.movScreen.Recording.2023-02-11.at.1.57.05.PM.mov |
|
@amirfakhrullah Works great 👏. In the first video just make sure there are no double borders in the delete item |
|
Done @Udit-takkar . Here's the vid: Screen.Recording.2023-02-11.at.3.16.23.PM.mov |
|
@Udit-takkar is there anything else I need to update in here? |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
There was a problem hiding this comment.
@amirfakhrullah thanks for working on this.
I have made some changes. just to be consistent on how we are using dropdown in codebase
|
I see. Happy to contribute 🚀 |
What does this PR do?
Fixes #6992
Screen.Recording.2023-02-10.at.8.30.54.PM.mov
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
/event-types