Skip to content

[CAL-1030] fix flickering border issue in menu layout for mobile#7036

Merged
PeerRich merged 4 commits intocalcom:mainfrom
amirfakhrullah:fix/cal-1030
Feb 13, 2023
Merged

[CAL-1030] fix flickering border issue in menu layout for mobile#7036
PeerRich merged 4 commits intocalcom:mainfrom
amirfakhrullah:fix/cal-1030

Conversation

@amirfakhrullah
Copy link
Copy Markdown
Contributor

@amirfakhrullah amirfakhrullah commented Feb 10, 2023

What does this PR do?

  • Fixing the flickering border issue in menu layout for mobile

Fixes #6992

Screen.Recording.2023-02-10.at.8.30.54.PM.mov

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Run the web app locally and go to /event-types
  • Test the menu layout

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:35PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:35PM (UTC)

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2023

@amirfakhrullah is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@Udit-takkar
Copy link
Copy Markdown
Contributor

@amirfakhrullah try to use DropdownItem inside DropdownMenuItem if possible just like it is used in other parts of codebase

@amirfakhrullah
Copy link
Copy Markdown
Contributor Author

@Udit-takkar I just changed it. I can confirm that all pages/sections that use the DropdownMenuItem component working fine:

Screen.Recording.2023-02-11.at.1.56.42.PM.mov
Screen.Recording.2023-02-11.at.1.57.05.PM.mov

@Udit-takkar
Copy link
Copy Markdown
Contributor

@amirfakhrullah Works great 👏. In the first video just make sure there are no double borders in the delete item

@amirfakhrullah
Copy link
Copy Markdown
Contributor Author

Done @Udit-takkar . Here's the vid:

Screen.Recording.2023-02-11.at.3.16.23.PM.mov

@amirfakhrullah
Copy link
Copy Markdown
Contributor Author

@Udit-takkar is there anything else I need to update in here?

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirfakhrullah thanks for working on this.
I have made some changes. just to be consistent on how we are using dropdown in codebase

@amirfakhrullah
Copy link
Copy Markdown
Contributor Author

I see. Happy to contribute 🚀

@PeerRich PeerRich merged commit bef6d18 into calcom:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1030] mobile dropdown menu layout issues

3 participants