Fix: avatar group buggy with +0#7044
Merged
PeerRich merged 6 commits intocalcom:mainfrom Feb 11, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@amirfakhrullah is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
PeerRich
reviewed
Feb 11, 2023
PeerRich
approved these changes
Feb 11, 2023
Comment on lines
+46
to
+48
| "relative -mr-[4px] mb-1 inline-flex justify-center overflow-hidden rounded-full bg-darkgray-300", | ||
| props.size === "sm" ? "min-w-6 h-6" : "min-w-16 h-16" | ||
| )}> |
Member
There was a problem hiding this comment.
after seeing bg-black in action i decided to change it to bg-darkgray-300
Contributor
Author
There was a problem hiding this comment.
@PeerRich I saw that the lint workflow failed due to the classname order rule, so I pushed a commit to fix that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
AvatarGroupscomponent to follow: https://www.figma.com/file/9MOufQNLtdkpnDucmNX10R/%E2%9D%96-Cal-DS?node-id=1573%3A77871&t=I8UQXj6AtCkQ0f0E-0Fixes #7032
In-case the truncated avatars are more that 1 digits
For this video, behind the scenes (on my IDE) I'm changing the
truncatedAfterprop value from 3 -> 1 -> 2 -> 3 -> 4. You can see the behaviour as below:Screen.Recording.2023-02-11.at.2.15.33.PM.mov
Environment: Staging(main branch) / Pr
Type of change
How should this be tested?