[CAL-925] fix: add null check for userSchedule.availability#7053
Merged
emrysal merged 1 commit intocalcom:mainfrom Feb 13, 2023
ShaneMaglangit:fix/cal-925
Merged
[CAL-925] fix: add null check for userSchedule.availability#7053emrysal merged 1 commit intocalcom:mainfrom ShaneMaglangit:fix/cal-925
emrysal merged 1 commit intocalcom:mainfrom
ShaneMaglangit:fix/cal-925
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@ShaneMaglangit is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
emrysal
approved these changes
Feb 13, 2023
| : { | ||
| ...userSchedule, | ||
| availability: userSchedule.availability.map((a) => ({ | ||
| availability: userSchedule?.availability.map((a) => ({ |
Contributor
There was a problem hiding this comment.
Suggested change
| availability: userSchedule?.availability.map((a) => ({ | |
| // FIXME: Default Schedule can be null if the user has no schedules at all | |
| // - Create testcases & test through the behaviour in this edge case. | |
| availability: userSchedule?.availability.map((a) => ({ |
Contributor
|
Thank you for your contribution! I added a FIXME so we will come back to this later to handle the situation with no availability better; but this fixes the hard crash 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6708
This issue seems to appear when the user does not have any availability created.
Environment: Production
Type of change
How should this be tested?
Checklist