Skip to content

Ability to write placeholder in routing forms#7054

Merged
hariombalhara merged 1 commit intocalcom:mainfrom
darshandamre:routing-forms-placeholder
Feb 13, 2023
Merged

Ability to write placeholder in routing forms#7054
hariombalhara merged 1 commit intocalcom:mainfrom
darshandamre:routing-forms-placeholder

Conversation

@darshandamre
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an input field to write a placeholder text in routing form edits and shows this text as placeholder in forms.

Fixes #7035

image

image

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 11, 2023

@darshandamre is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 1:07PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:07PM (UTC)

Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for the contribution @darshandamre

@hariombalhara hariombalhara merged commit 74fe208 into calcom:main Feb 13, 2023
@PeerRich
Copy link
Copy Markdown
Member

awesome work @darshandamre

@shirazdole
Copy link
Copy Markdown

very nice @darshandamre !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1040] routing-forms: ability to write a placeholder

4 participants