chore: turn inline logo & shell headers into h3#7060
chore: turn inline logo & shell headers into h3#7060emrysal merged 1 commit intocalcom:mainfrom p6l-richard:main
Conversation
|
@p6l-richard is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'd also like an opinion from @JeroenReumkens on this - I agree with this change but also question whether h3 is the right alternative. |
Putting my input here too -> I agree with this change - No reason at all for logo to be H1. H3 is fine from a a11y standpoint |
emrysal
left a comment
There was a problem hiding this comment.
Approved as clarified by @sean-brydon
|
The This also shows that you can't skip levels (so no h3 without an h2), and also proves the point that the logo isn't an h3, because it's not suddenly a sub chapter of anything. So it should actually be a paragraph 😁 |
|
Yeah that was my idea as well @JeroenReumkens - I wasn't sure if it was "best" to have h3, but the main problem was with the h1 so was good to merge. |
What does this PR do?
Environment: Staging(main branch) / Production
Type of change