feat: Added more query params to successRedirect page by titanventura · Pull Request #8271 · calcom/cal.diy

titanventura · 2023-04-14T15:39:11Z

What does this PR do?

Pass extra booking params to redirect URL
Fixes #7802

Edit by @hariombalhara

Right now there is an option to enable sending these query params in this PR.

A sample redirect URL generated using the avove configuration https://www.google.com/?isSuccessBookingPage=true&email=d%40e.com&eventTypeSlug=abc&title=ABC+between+Team+Pro+Example+and+d&description=sd&startTime=2023-05-12T03%3A45%3A00.000Z&endTime=2023-05-12T04%3A00%3A00.000Z&location=integrations%3Awhereby_video

Params Sent to Custom Success Redirect Page

booker_email - Email of the person booking the meeting.
title - Booking Title
description - Additional Notes of the booking
startTime - Booking Start Time as ISO String (Sample 2023-05-12T03:45:00.000Z)
endTime - Booking End Time as ISO String(Sample 2023-05-12T04:00:00.000Z)
location - It has many possible values. For Video Apps, the value will be in format integrations:{APPNAME}_video e.g. integrations:whereby_video. See more possible values for it here

I am of the opinion that we should do it by default and that checkbox isn't required. There is a very edge case where sending a lot of query params can break the URL size limit but we can ignore that for now.
cc @PeerRich @Jaibles

Type of change

New feature (non-breaking change which adds functionality)

Checklist

I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2023-04-14T15:39:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2023 0:12am

vercel · 2023-04-14T15:39:17Z

@titanventura is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

sean-brydon

Thanks for the contribution :) Havent tested but lets not implement lodash - especially in our booking page

Its huge

github-actions · 2023-04-14T15:52:34Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

titanventura · 2023-04-14T16:18:44Z

Thanks for the support ! I would like to thank @adarsh-a-tw - link who paired with me and helped me raise this PR !

titanventura · 2023-04-16T07:15:30Z

@sean-brydon Please review. Thanks !

github-actions · 2023-04-18T10:09:21Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]/book`	`189.37 KB`	420.67 KB	120.19% (🟡 +0.17%)
`/apps/[slug]/[...pages]`	`389.09 KB`	620.38 KB	177.25% (🟢 -0.17%)
`/auth/setup`	`81.58 KB`	312.87 KB	89.39% (🟢 -0.17%)
`/d/[link]/book`	`189.02 KB`	420.31 KB	120.09% (🟡 +0.17%)
`/team/[slug]/book`	`189.02 KB`	420.31 KB	120.09% (🟡 +0.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

github-actions · 2023-04-18T17:56:44Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

titanventura · 2023-04-18T18:20:42Z

Please review !

hariombalhara · 2023-04-19T13:34:13Z

        eventTypeSlug: eventType.slug,
        seatReferenceUid: "seatReferenceUid" in responseData ? responseData.seatReferenceUid : null,
        ...(rescheduleUid && booking?.startTime && { formerTime: booking.startTime.toString() }),
+        ...getBookingRedirectExtraParams(responseData),


This should be done as part of bookingSuccessRedirect and that fn is called at multiple places as redirections happens from multiple places.

hariombalhara · 2023-04-19T13:42:27Z

+      "startTime",
+      "endTime",
+      "location",
+      ...objectQueryParamKeys,


Instead of differentiating manually b/w object and non-object params, we should use the typeof operator to identify the value. This would allow us to maintain a single list.

Also, I would like to keep the list very strict because whatever we expose has to be considered for backward compatibility as websites would rely on those params.

Stable Params - Good to be passed as is

title

description

startTime

endTime

location

user and attendees might have different props depending on what we queried. So, we need to pick keys specifically from here. So, it might be better to remove these keys and wait for a requirement from users as to what they use it for.

hariombalhara

Left some comments.

titanventura · 2023-04-19T19:07:51Z

thanks for the suggestions @hariombalhara . Have made the changes. Please review !

titanventura · 2023-04-25T17:38:39Z

Any updates on this ?

github-actions · 2023-07-24T12:12:14Z

Thank you for following the naming conventions! 🙏

hariombalhara · 2023-07-24T13:31:19Z

@titanventura Are you there to review the changes I pushed?

I have made the changes to send email as new param booker_email so that it's clear whose email it is. Also documented, the params that are are sending.
I have also pulled in latest main and resolved some conflicts.

I have also ensured that no other query param is sent that isn't in documentation.

hariombalhara · 2023-07-24T13:37:24Z

  price: true,
  slug: true,
  length: true,
-  offsetStart: true,


Why are these changes made in managedEventTypes ?

github-actions · 2023-08-10T00:18:18Z

This PR is being marked as stale due to inactivity.

PeerRich · 2023-08-14T06:28:42Z

/bonus 20 @titanventura can you take another look at this PR and fix the merge conflicts? <3

algora-pbc · 2023-08-14T06:28:47Z

A bonus of $20 has been added by PeerRich.
@titanventura: You will receive $20 once you implement the requested changes and your PR is merged.

hariombalhara

LGTM now !! Thanks @titanventura

Resolved

algora-pbc · 2023-08-22T12:18:48Z

@titanventura: Your claim has been rewarded! 👉 Complete your Algora onboarding to collect the bounty.

algora-pbc · 2023-08-22T12:58:01Z

🎉🎈 @titanventura has been awarded $20! 🎈🎊

titanventura requested a review from a team April 14, 2023 15:39

vercel Bot deployed to Preview – ui April 14, 2023 15:44 View deployment

sean-brydon reviewed Apr 14, 2023

View reviewed changes

Comment thread apps/web/components/booking/pages/BookingPage.tsx Outdated

sean-brydon previously requested changes Apr 14, 2023

View reviewed changes

vercel Bot deployed to Preview – ui April 14, 2023 16:20 View deployment

vercel Bot deployed to Preview – ui April 16, 2023 07:20 View deployment

vercel Bot deployed to Preview – ui April 18, 2023 10:07 View deployment

vercel Bot deployed to Preview – ui April 18, 2023 17:45 View deployment

vercel Bot deployed to Preview – ui April 18, 2023 17:54 View deployment

titanventura requested a review from sean-brydon April 18, 2023 18:23

hariombalhara reviewed Apr 19, 2023

View reviewed changes

Comment thread apps/web/components/booking/pages/BookingPage.tsx Outdated

hariombalhara reviewed Apr 19, 2023

View reviewed changes

hariombalhara requested changes Apr 19, 2023

View reviewed changes

vercel Bot deployed to Preview – ui April 19, 2023 14:53 View deployment

titanventura requested a review from alannnc as a code owner April 19, 2023 18:44

titanventura requested a review from a team April 19, 2023 18:44

vercel Bot deployed to Preview – ui April 19, 2023 18:52 View deployment

titanventura requested a review from hariombalhara April 19, 2023 19:07

vercel Bot deployed to Preview – ui April 25, 2023 17:44 View deployment

vercel Bot deployed to Preview – ui July 24, 2023 12:29 View deployment

vercel Bot deployed to Preview – ui July 24, 2023 13:17 View deployment

vercel Bot deployed to Preview – ui July 24, 2023 13:32 View deployment

hariombalhara reviewed Jul 24, 2023

View reviewed changes

github-actions Bot removed the Stale label Jul 25, 2023

github-actions Bot added the Stale label Aug 10, 2023

fix: pass extra booking query params to redirect url (calcom#7802)

bd29cf6

titanventura force-pushed the main branch from 41c9ade to bd29cf6 Compare August 15, 2023 06:37

titanventura requested a review from hariombalhara August 15, 2023 06:38

vercel Bot deployed to Preview – ui August 15, 2023 06:40 View deployment

github-actions Bot removed the Stale label Aug 16, 2023

Merge remote-tracking branch 'origin/main'

15e516b

vercel Bot deployed to Preview – ui August 22, 2023 11:38 View deployment

Fix crash on payment page due to endTime being not serializable

7e5d917

hariombalhara changed the title ~~feat: Added option to pass extra booking query params to redirect url~~ feat: Added more query params to successRedirect page Aug 22, 2023

hariombalhara approved these changes Aug 22, 2023

View reviewed changes

hariombalhara enabled auto-merge (squash) August 22, 2023 12:10

vercel Bot deployed to Preview – ui August 22, 2023 12:12 View deployment

hariombalhara merged commit 16bb5c3 into calcom:main Aug 22, 2023

algora-pbc Bot added the 💰 Rewarded Rewarded bounties on Algora.io label Aug 22, 2023

MyPsyOnline mentioned this pull request Aug 28, 2023

pass id of the event in redirect url #10841

Closed

Conversation

titanventura commented Apr 14, 2023 • edited by hariombalhara Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Edit by @hariombalhara

Type of change

Checklist

Uh oh!

vercel Bot commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Apr 14, 2023

Uh oh!

Uh oh!

sean-brydon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

titanventura commented Apr 14, 2023

Uh oh!

titanventura commented Apr 16, 2023

Uh oh!

github-actions Bot commented Apr 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

Five Pages Changed Size

Uh oh!

github-actions Bot commented Apr 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

titanventura commented Apr 18, 2023

Uh oh!

Uh oh!

hariombalhara Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

titanventura commented Apr 19, 2023

Uh oh!

titanventura commented Apr 25, 2023

Uh oh!

github-actions Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 10, 2023

Uh oh!

PeerRich commented Aug 14, 2023

Uh oh!

algora-pbc Bot commented Aug 14, 2023

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

algora-pbc Bot commented Aug 22, 2023

Uh oh!

algora-pbc Bot commented Aug 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

titanventura commented Apr 14, 2023 •

edited by hariombalhara

Loading

vercel Bot commented Apr 14, 2023 •

edited

Loading

sean-brydon left a comment •

edited

Loading

github-actions Bot commented Apr 14, 2023 •

edited

Loading

github-actions Bot commented Jul 24, 2023 •

edited

Loading

hariombalhara commented Jul 24, 2023 •

edited

Loading