Skip to content

chore: UI username RTL#8300

Merged
PeerRich merged 4 commits into
calcom:mainfrom
a0m0rajab:main
Apr 16, 2023
Merged

chore: UI username RTL#8300
PeerRich merged 4 commits into
calcom:mainfrom
a0m0rajab:main

Conversation

@a0m0rajab
Copy link
Copy Markdown
Contributor

What does this PR do?

This fixes one of the UI issues in the RTL view that's related to the username.
Related to: #8151

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Check if the image is correct:

image

@a0m0rajab a0m0rajab requested a review from a team April 15, 2023 15:13
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 7:32pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 7:32pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

@a0m0rajab is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 389.04 KB 620.31 KB 177.23% (🟢 -0.18%)
/auth/setup 81.57 KB 312.84 KB 89.38% (🟢 -0.17%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Comment thread packages/ui/components/form/inputs/Input.tsx Outdated
@PeerRich
Copy link
Copy Markdown
Member

thanmk you! wil test and merge

@PeerRich
Copy link
Copy Markdown
Member

can you run ´yarn format´ on root?

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good on ltr and rtl

@PeerRich PeerRich enabled auto-merge (squash) April 16, 2023 14:38
@a0m0rajab
Copy link
Copy Markdown
Contributor Author

@PeerRich Thank you for that! I will keep working on the issue and open the related PRs.

Comment thread packages/ui/components/form/inputs/Input.tsx Outdated
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Apr 16, 2023
@PeerRich PeerRich disabled auto-merge April 16, 2023 19:18
@PeerRich PeerRich enabled auto-merge (squash) April 16, 2023 19:18
@PeerRich PeerRich requested review from a team and removed request for a team April 16, 2023 19:18
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants