Skip to content

perf: improve booking confirm authorization#8304

Merged
roae merged 4 commits into
calcom:mainfrom
anonrig:perf-booking-confirm
Apr 17, 2023
Merged

perf: improve booking confirm authorization#8304
roae merged 4 commits into
calcom:mainfrom
anonrig:perf-booking-confirm

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Apr 15, 2023

Previous implementation was wrong and unperformant. This pull request fixes the following bug, and reduces application layer data and moves some comparison to the database layer.

eventType.users.find((user) => user.id === user.id)

(It was always returning truthy)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 11:41pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 11:41pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

@anonrig is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

@roae roae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙏

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Apr 17, 2023
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Comment thread packages/trpc/server/routers/viewer/bookings.tsx
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@roae roae merged commit ad958f1 into calcom:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants