Skip to content

fix: scroll-bar class for editor compnent#8310

Merged
PeerRich merged 1 commit into
calcom:mainfrom
joe-shajan:scrollbar
Apr 16, 2023
Merged

fix: scroll-bar class for editor compnent#8310
PeerRich merged 1 commit into
calcom:mainfrom
joe-shajan:scrollbar

Conversation

@joe-shajan
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #8254

I have added the scroll-bar class in Editor component which fixed the issue in that particular component.

But in the installed apps I think the current scroll is not not working as expected and because of that adding scroll-bar class won't make it work. need some help with that.

image

screenshots for editor component

Before

new event type dialog before

After

new event type dialog 1

new event type dialog 2

event setup description after

profile page after

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@joe-shajan joe-shajan requested a review from a team April 16, 2023 16:42
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 4:50pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2023

@joe-shajan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 389.05 KB 620.35 KB 177.24% (🟢 -0.17%)
/auth/setup 81.58 KB 312.88 KB 89.39% (🟢 -0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich merged commit 88d151a into calcom:main Apr 16, 2023
@joe-shajan joe-shajan deleted the scrollbar branch April 23, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1486] windows: scroll bar

2 participants