feat: Support adding links to checkbox type question using markdown[Blocked on another PR]#8943
Conversation
CAL-1650 Ability to Hyperlink in Checkbox Field
A lot of healthcare companies will need this and has been asked for by a few customers CleanShot 2023-05-10 at 17.42.232x.png |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
PeerRich
changed the title
|
pretty sure this has been build before, no? am I trippin? |
|
@PeerRich maybe you saw #8939? |
|
ahhh that explains |
hariombalhara
changed the title
hariombalhara
force-pushed
the
hariom/cal-1650-ability-to-hyperlink-in-checkbox-field
branch
from
523cea4 to
ee9e874
Compare
|
This PR is being marked as stale due to inactivity. |
|
This PR is being closed due to inactivity. Please reopen if work is intended to be continued. |
|
@hariombalhara we still want this to merge after #8671 right? |
|
Yeah for sure. Been waiting for that to happen 😄 |
|
This PR is being marked as stale due to inactivity. |
hariombalhara
force-pushed
the
hariom/cal-1650-ability-to-hyperlink-in-checkbox-field
branch
from
ee9e874 to
be7a370
Compare
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Ninety-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
@CarinaWolli Up for review again. |
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
Getting this when trying to use a link for a booking question of type 'Long Text':
|
Yeah only checkbox is supported at the moment |
|
|
|
Ah I accidentally pushed textarea 😕 |
|
Fixed. |
|
🤖 Meticulous spotted visual differences in 76 of 188 screens tested: view and approve differences detected. Last updated for commit a7aa559. This comment will update as new commits are pushed. |
Current Playwright Test Results Summary✅ 72 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/21/2023 05:30:30pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a7aa559 Started: 07/21/2023 05:29:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
1.84% (6)6 / 326 runsfailed over last 7 days |
7.98% (26)26 / 326 runsflaked over last 7 days |
hariombalhara
deleted the
hariom/cal-1650-ability-to-hyperlink-in-checkbox-field
branch
…locked on another PR] (calcom#8943) * Support adding links in boolean checkbox * Fix and comment * remove textarea, it was accidentally pushed.
4 participants
What does this PR do?
Fixes #8829
[text](link)in checkbox type field label to add a linkfieldsThatSupportLabelAsSafeHtmlDemo
https://www.loom.com/share/f6a4423161374fc2a67026505b3e66d6
Followup
TODO:
Type of change
How should this be tested?
Checklist