fix: data collection for headless router

[hariombalhara]

What does this PR do?

• Headless Router(/router?form={FORM_ID}) was just doing the routing but not collecting the form responses. This PR fixes that
• Comma separated strings were supported for Routing Forms prefill and Headless router but they weren't working correctly. It's fixed now.

Demo showing Headless router collects data now

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Create a Routing Form with different types of fields and see that reporting shows the collected data
• Create a Routing Form with different types of fields and see that routing is working with all types of fields.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 10:42am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 10:42am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 10:42am

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 23, 2023 10:42am
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 23, 2023 10:42am
ui	⬜️ Ignored (Inspect)	Visit Preview		Aug 23, 2023 10:42am

[github-actions]

This PR is being marked as stale due to inactivity.

[github-actions]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

[github-actions]

Thank you for following the naming conventions! 🙏

[hariombalhara]

It's an important PR. Will work on it one high priority things are done

[alwaysmeticulous]

🤖 Meticulous spotted visual differences in 53 of 174 screens tested: view and approve differences detected.

_{Last updated for commit ac26aab. This comment will update as new commits are pushed.}

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
global	155.33 KB (🟡 +580 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/apps/[slug]/[...pages]	537.51 KB	692.84 KB	197.95% (🟡 +5.36%)
/settings/admin/users/[id]/edit	384.92 KB	540.25 KB	154.36% (🟡 +13.06%)
/settings/admin/users/add	384.59 KB	539.92 KB	154.26% (🟡 +13.06%)
/settings/my-account/general	381.48 KB	536.81 KB	153.37% (🟡 +12.88%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

[hariombalhara]

Thanks for the review @ologbonowiwi. Accepted your suggestions 🙏

[CarinaWolli]

Works and code looks good 👏🏻