Skip to content

fix: [CAL-1733] Revalidate Issue on Event-Type Page#9191

Merged
hariombalhara merged 2 commits into
mainfrom
fix/revalidate-issue-on-event-type
Jun 1, 2023
Merged

fix: [CAL-1733] Revalidate Issue on Event-Type Page#9191
hariombalhara merged 2 commits into
mainfrom
fix/revalidate-issue-on-event-type

Conversation

@roae
Copy link
Copy Markdown
Contributor

@roae roae commented May 29, 2023

What does this PR do?

Prevents revalidation errors from reaching the user when editing an event type.

These errors occur when the event type configuration doesn't allow to create the event type public page.

Fixes #9032

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@linear
Copy link
Copy Markdown

linear Bot commented May 29, 2023

CAL-1733 Revalidate Issue on Event-Type Page

Whenever I make changes to my event-type, and I try to save, I get presented with this issue. Changing location, changing duration, adding confirmation, all of them.

CleanShot 2023-05-22 at 10.51.542x.png

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:38pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:38pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:38pm

@github-actions github-actions Bot added Urgent Created by Linear-GitHub Sync 🐛 bug Something isn't working labels May 29, 2023
@roae roae changed the title fix/[CAL-1733] Revalidate Issue on Event-Type Page fix: [CAL-1733] Revalidate Issue on Event-Type Page May 29, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 458.93 KB 609.89 KB 174.25% (🟡 +0.18%)
/apps/installed/[category] 277.87 KB 428.83 KB 122.52% (🟢 -0.20%)
/auth/setup 174.84 KB 325.79 KB 93.08% (🟡 +0.15%)
/bookings/[status] 342.16 KB 493.12 KB 140.89% (🟡 +0.21%)
/event-types/[type] 480.18 KB 631.14 KB 180.33% (🟡 +0.34%)
/getting-started/[[...step]] 426.21 KB 577.17 KB 164.90% (🟢 -0.24%)
/settings/my-account/calendars 252.29 KB 403.25 KB 115.21% (🟢 -0.30%)
/settings/my-account/general 327.56 KB 478.52 KB 136.72% (🟢 -1.20%)
/workflows/[workflow] 368.97 KB 519.93 KB 148.55% (🟡 +0.21%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented May 29, 2023

No failed tests 🎉

@hariombalhara hariombalhara added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit 60d439c Jun 1, 2023
@hariombalhara hariombalhara deleted the fix/revalidate-issue-on-event-type branch June 1, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working Urgent Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1733] Revalidate Issue on Event-Type Page

3 participants