Skip to content

fix: #9217 | redirected unready /settings/admin to one of its tabs#9222

Merged
hariombalhara merged 1 commit into
calcom:mainfrom
sohamdata:fixAdminRedirect
Jun 13, 2023
Merged

fix: #9217 | redirected unready /settings/admin to one of its tabs#9222
hariombalhara merged 1 commit into
calcom:mainfrom
sohamdata:fixAdminRedirect

Conversation

@sohamdata
Copy link
Copy Markdown
Contributor

@sohamdata sohamdata commented May 31, 2023

What does this PR do?

Fixes #9217
Redirected the unready settings/admin route to its flags tab

Demo

fix

Type of change

  • Bug fix

@vercel
Copy link
Copy Markdown

vercel Bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 8:45am

@vercel
Copy link
Copy Markdown

vercel Bot commented May 31, 2023

@sohamdata is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.47 KB 406.65 KB 116.19% (🟡 +0.14%)
/apps/[slug]/[...pages] 458.31 KB 609.49 KB 174.14% (🟢 -0.25%)
/auth/setup 174.33 KB 325.52 KB 93.01% (🟢 -0.17%)
/d/[link]/book 255.11 KB 406.3 KB 116.09% (🟡 +0.14%)
/event-types/[type] 478.98 KB 630.17 KB 180.05% (🟢 -0.19%)
/getting-started/[[...step]] 427.07 KB 578.26 KB 165.22% (🟡 +0.22%)
/new-booker/[user]/[type] 290.73 KB 441.92 KB 126.26% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 290.73 KB 441.92 KB 126.26% (🟡 +0.14%)
/settings/my-account/calendars 253.36 KB 404.55 KB 115.59% (🟡 +0.23%)
/team/[slug]/book 255.11 KB 406.3 KB 116.09% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode requested a review from a team June 1, 2023 21:55
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jun 6, 2023
@sohamdata
Copy link
Copy Markdown
Contributor Author

@hariombalhara any update?

@hariombalhara hariombalhara requested review from a team and hariombalhara and removed request for a team June 13, 2023 10:45
@hariombalhara hariombalhara added this pull request to the merge queue Jun 13, 2023
@hariombalhara
Copy link
Copy Markdown
Member

Thanks @sohamdata. LGTM!!

Merged via the queue into calcom:main with commit 2639ef7 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Low priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No reviews

Development

Successfully merging this pull request may close these issues.

[CAL-1828] settings/admin page isn't ready but it's in production

3 participants