Skip to content

fix: insights-date-picker-same-time-start-end-date#9252

Merged
zomars merged 1 commit into
mainfrom
fix/insights-date-time-picker-8173-cal-1443
May 31, 2023
Merged

fix: insights-date-picker-same-time-start-end-date#9252
zomars merged 1 commit into
mainfrom
fix/insights-date-time-picker-8173-cal-1443

Conversation

@alannnc
Copy link
Copy Markdown
Contributor

@alannnc alannnc commented May 31, 2023

What does this PR do?

  • Should handle start, end dates correctly with startOf() endOf() day.

Fixes #8173

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to any insights page select any quick date from the DateSelect Filter
  • Url should have correct startDate and endDate.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@linear
Copy link
Copy Markdown

linear Bot commented May 31, 2023

CAL-1443 Insights date time picker returns same startDate and endDate

User reported some issues on their insights page, looks like browser Edge doesn't return good startDate and endDate when using time frame picker.

image.png

@vercel
Copy link
Copy Markdown

vercel Bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 7:50pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 7:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) May 31, 2023 7:50pm

@github-actions github-actions Bot added the 🐛 bug Something isn't working label May 31, 2023
@alannnc alannnc requested review from emrysal and zomars May 31, 2023 19:48
@alannnc alannnc changed the title fix/insights-date-picker-same-time-start-end-date fix:insights-date-picker-same-time-start-end-date May 31, 2023
@alannnc alannnc changed the title fix:insights-date-picker-same-time-start-end-date fix: insights-date-picker-same-time-start-end-date May 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@zomars zomars added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit 7a9b893 May 31, 2023
@zomars zomars deleted the fix/insights-date-time-picker-8173-cal-1443 branch May 31, 2023 22:23
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1443] Insights date time picker returns same startDate and endDate

3 participants