Skip to content

fix: use skeleton loader in feature flag page#9264

Merged
PeerRich merged 1 commit into
mainfrom
fix-featureflag-loader
Jun 1, 2023
Merged

fix: use skeleton loader in feature flag page#9264
PeerRich merged 1 commit into
mainfrom
fix-featureflag-loader

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Jun 1, 2023

What does this PR do?

after:

Screencast.2023-06-01.17.30.32.webm

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 0:07am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 0:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Jun 1, 2023 0:07am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 1, 2023

Current Playwright Test Results Summary

✅ 90 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/01/2023 12:14:54pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a3cbcfa

Started: 06/01/2023 12:13:18pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to disable 2FA
Retry 1Initial Attempt
0% (0) 0 / 184 runs
failed over last 7 days
14.67% (27) 27 / 184 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low prio but good change

@PeerRich PeerRich added this pull request to the merge queue Jun 1, 2023
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jun 1, 2023
Merged via the queue into main with commit df25b17 Jun 1, 2023
@PeerRich PeerRich deleted the fix-featureflag-loader branch June 1, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Low priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants