feat: organizations sidebar#9395
Merged
Merged
Conversation
* Change scopedMembers to orgMembers * Change to orgUsers
….com into feat/organizations-onboarding
….com into feat/organizations-onboarding
* Adding check for cache hit * Adding a separate install step first * Put the restore cache steps back * Revert the uses type for restoring cache * Added step to restore nm cache * Removed the cache-hit check * Comments and naming * Removed extra install command * Updated the name of the linting step to be more clear
…m/cal.com into feat/organizations-sidebar
# Conflicts: # .env.example # apps/web/public/static/locales/en/common.json # packages/emails/src/templates/OrganizationAccountVerifyEmail.tsx # packages/features/shell/Shell.tsx
Member
|
|
hariombalhara
approved these changes
Jun 15, 2023
Member
There was a problem hiding this comment.
LGTM!!
Tested
- KBar
- Links at the bottom of sidebar
- Away status toggle
- Long username
- Long teamname
- Different screensizes
Non Blocker Issues
- Skeleton Missing - Bug filed
Fixed one issue:
- Removed hovered effect that was there on
Copy Page Linkwithout hovering
… feat/organizations-sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Organization member
Simple user
Type of change