Skip to content

docs: improving developer experience#9432

Merged
keithwillcode merged 12 commits into
calcom:mainfrom
a0m0rajab:dx-improve
Jun 19, 2023
Merged

docs: improving developer experience#9432
keithwillcode merged 12 commits into
calcom:mainfrom
a0m0rajab:dx-improve

Conversation

@a0m0rajab
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR helps to improve the developer experience by adding the next:

  • Feedback if conventional commit was not followed
  • Welcoming new users

relates #9343

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

How should this be tested?

This can be tested when a new PR is opened or a new Issue has been opened by first contributors.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Jun 19, 2023 2:51pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2023

@a0m0rajab is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! Just have a few things we should update.

Comment thread .github/workflows/semantic-pull-requests.yml
Comment thread .github/workflows/semantic-pull-requests.yml Outdated
Comment thread .github/workflows/welcome-newers.yml Outdated
@@ -0,0 +1,28 @@
name: "Welcome new contributors"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this filename to be welcome-new-contributors. welcome-newers sounds odd

Comment thread .github/workflows/welcome-newers.yml Outdated
Comment thread .github/workflows/welcome-newers.yml Outdated
@a0m0rajab
Copy link
Copy Markdown
Contributor Author

Updated the PR based on @keithwillcode comments.

@keithwillcode keithwillcode changed the title docs: improving developer experience improving developer experience Jun 19, 2023
@keithwillcode
Copy link
Copy Markdown
Contributor

@a0m0rajab Thanks for the updates! I'm going to test this out.

@keithwillcode keithwillcode changed the title improving developer experience docs: improving developer experience Jun 19, 2023
@a0m0rajab
Copy link
Copy Markdown
Contributor Author

@keithwillcode Thank you for merging this! Will be working on the other suggestions when I got the bandwidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No reviews

Development

Successfully merging this pull request may close these issues.

2 participants