Skip to content

docs: Added command in manual section#9433

Merged
PeerRich merged 7 commits into
calcom:mainfrom
KavanGandhi:kavan/new-change
Jun 12, 2023
Merged

docs: Added command in manual section#9433
PeerRich merged 7 commits into
calcom:mainfrom
KavanGandhi:kavan/new-change

Conversation

@KavanGandhi
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is about making required changes according to the issue in documentation i.e the README.MD file.

Fixes #9414

Type of change

This change requires a documentation update

  • In ReadMe.md file, manual setup section didn't had the migration command for development environment, it only had the command for production environment. So now it's fixed.
readme-md

How should this be tested?

There is no need of testing. You can take a glance at changes made.

Mandatory Tasks

Yes I have self reviewed the code and made the required changes.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 6:20pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2023

@KavanGandhi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@KavanGandhi KavanGandhi changed the title Changes done in Read.md file docs: Added command in manual section Jun 9, 2023
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jun 9, 2023

not sure if its a good idea to have a env committed.

definitely uncommit yarn.lock 🙏

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KavanGandhi you would have to remove env and yarn.lock file.

you can look up on the internet. I think this command could help git checkout origin/main yarn.lock and then pushing the changes.

@KavanGandhi
Copy link
Copy Markdown
Contributor Author

@KavanGandhi you would have to remove env and yarn.lock file.

you can look up on the internet. I think this command could help git checkout origin/main yarn.lock and then pushing the changes.

@KavanGandhi KavanGandhi reopened this Jun 12, 2023
@KavanGandhi
Copy link
Copy Markdown
Contributor Author

@Udit-takkar Actually I have done the same thing you told. But the problem is if I don't upload these files then some checks here in pull requests are getting failed. So what should I do? Can you suggest.

@KavanGandhi
Copy link
Copy Markdown
Contributor Author

@Udit-takkar I have removed both files. Now can you review my PR?

Udit Takkar added 2 commits June 12, 2023 23:20
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do not delete yarn.lock just had to use the command git checkout origin/main yarn.lock. I have fixed this PR now

@KavanGandhi
Copy link
Copy Markdown
Contributor Author

@Udit-takkar So now I have to do anything as my PR is still not merged? As I'm doing it for first time I don't have much idea. Can you tell me about it? Because it's showing authorization required to deploy.

@PeerRich PeerRich disabled auto-merge June 12, 2023 20:46
@PeerRich PeerRich merged commit 3ec9eb3 into calcom:main Jun 12, 2023
@PeerRich
Copy link
Copy Markdown
Member

thank you @KavanGandhi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No reviews

Development

Successfully merging this pull request may close these issues.

need a change in documentation

3 participants