Skip to content

fix: team bio#9438

Merged
CarinaWolli merged 2 commits intomainfrom
fix/team-bio
Jun 9, 2023
Merged

fix: team bio#9438
CarinaWolli merged 2 commits intomainfrom
fix/team-bio

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli commented Jun 9, 2023

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 0:47am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 0:47am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 0:47am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 0:47am

@CarinaWolli CarinaWolli requested a review from emrysal June 9, 2023 12:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 252.51 KB 403.5 KB 115.28% (🟢 -0.27%)
/apps/installed/[category] 276.49 KB 427.47 KB 122.14% (🟢 -0.20%)
/d/[link]/book 252.16 KB 403.14 KB 115.18% (🟢 -0.27%)
/getting-started/[[...step]] 424.71 KB 575.7 KB 164.49% (🟢 -0.23%)
/new-booker/[user]/[type] 393.33 KB 544.32 KB 155.52% (🔴 +28.75%)
/new-booker/d/[link]/[slug] 393.33 KB 544.31 KB 155.52% (🔴 +28.75%)
/new-booker/team/[slug]/[type] 393.33 KB 544.32 KB 155.52% (🔴 +28.75%)
/settings/my-account/calendars 251.07 KB 402.06 KB 114.87% (🟢 -0.23%)
/settings/teams/[id]/profile 436.22 KB 587.21 KB 167.77% (🟡 +19.41%)
/team/[slug] 224.54 KB 375.52 KB 107.29% (🟡 +19.55%)
/team/[slug]/book 252.16 KB 403.14 KB 115.18% (🟢 -0.27%)
/team/[slug]/embed 224.61 KB 375.59 KB 107.31% (🟡 +19.55%)
/video/[uid] 239.97 KB 390.96 KB 111.70% (🔴 +29.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 9, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 107 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/09/2023 12:49:57pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 44dd23c

Started: 06/09/2023 12:48:10pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt
1.35% (4) 4 / 296 runs
failed over last 7 days
17.57% (52) 52 / 296 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt
5.76% (11) 11 / 191 runs
failed over last 7 days
94.24% (180) 180 / 191 runs
flaked over last 7 days

View Detailed Build Results

@CarinaWolli CarinaWolli enabled auto-merge June 9, 2023 12:47
emrysal
emrysal approved these changes Jun 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥳

@CarinaWolli CarinaWolli added this pull request to the merge queue Jun 9, 2023
Merged via the queue into main with commit bfef5b1 Jun 9, 2023
@CarinaWolli CarinaWolli deleted the fix/team-bio branch June 9, 2023 12:59
emrysal pushed a commit that referenced this pull request Jun 9, 2023
@CarinaWolli @emrysal
fix: team bio (#9438)
c81f0d7 
* fix bio rendering

* fix type error

---------

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees

No one assigned

Labels

core area: core, team members only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarinaWolli @emrysal @keithwillcode @PeerRich