Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 107 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/10/2023 02:40:14am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e89f7a9 Started: 06/10/2023 02:37:58am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
5.26% (10)10 / 190 runsfailed over last 7 days |
94.74% (180)180 / 190 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
2.07% (6)6 / 290 runsfailed over last 7 days |
22.76% (66)66 / 290 runsflaked over last 7 days |
roae
previously requested changes
Jun 10, 2023
Contributor
roae
left a comment
roae
left a comment
There was a problem hiding this comment.
this is failing because it is not getting prisma correctly, leave a comment in the line where the error is
emrysal
force-pushed
the
bugfix/prevent-invalid-hosts
branch
from
3b8ec96 to
b489b55
Compare
emrysal
dismissed
roae’s stale review
Thanks, got there eventually (sadly didn't see your reply)
…com into bugfix/prevent-invalid-hosts
roae
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds extra checks while adding hosts.