fix: [CAL-1765] opt-in: clicking "confirm" or "reject" broken#9443
Merged
PeerRich merged 4 commits intoJun 10, 2023
Conversation
CAL-1765 opt-in: clicking "confirm" or "reject" broken
both buttons just goes to the booking page view |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
Bot
added
High priority
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 107 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/10/2023 02:52:56am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f67a5d8 Started: 06/10/2023 02:51:07am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
6.92% (20)20 / 289 runsfailed over last 7 days |
21.45% (62)62 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
2.05% (6)6 / 293 runsfailed over last 7 days |
23.21% (68)68 / 293 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
5.18% (10)10 / 193 runsfailed over last 7 days |
94.82% (183)183 / 193 runsflaked over last 7 days |
Udit-takkar
approved these changes
Jun 10, 2023
PeerRich
deleted the
hotfix/1765-opt-in-clicking-confirm-or-reject-broken
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support to a custom sessionGetter in trpc createContext
Fixes #9110
Type of change
How should this be tested?
Mandatory Tasks