Skip to content

test: Add E2E test to verify theme change#9455

Merged
keithwillcode merged 2 commits into
calcom:mainfrom
abhisheksunil2201:test/change-theme
Jun 12, 2023
Merged

test: Add E2E test to verify theme change#9455
keithwillcode merged 2 commits into
calcom:mainfrom
abhisheksunil2201:test/change-theme

Conversation

@abhisheksunil2201
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds end-to-end tests to verify if the theme has been applied successfully to public booking pages.

  • change-theme.e2e.ts
    • Verify if the theme change has been applied to the respective public booking page successfully
  • ThemeLabel.tsx
    • Added data-testid to the theme label

Fixes #5977
/claim #5977

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Run automated e2e tests

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

(all complete)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 3:44am

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 11, 2023

@abhisheksunil2201 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync 💎 Bounty A bounty on Algora.io automated-tests area: unit tests, e2e tests, playwright labels Jun 11, 2023
@abhisheksunil2201 abhisheksunil2201 changed the title Add E2E test to verify theme change test: Add E2E test to verify theme change Jun 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Copy Markdown
Contributor

@roae roae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some performance-related improvements need to be made

Comment thread apps/web/playwright/change-theme.e2e.ts Outdated
Comment thread apps/web/playwright/change-theme.e2e.ts Outdated
Comment thread apps/web/playwright/change-theme.e2e.ts Outdated
Comment thread packages/features/settings/ThemeLabel.tsx Outdated
Copy link
Copy Markdown
Contributor

@roae roae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhisheksunil2201 Thank you for the contribution 🙏

@roae roae added this pull request to the merge queue Jun 12, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 12, 2023
@keithwillcode keithwillcode added this pull request to the merge queue Jun 12, 2023
Merged via the queue into calcom:main with commit dbf11cc Jun 12, 2023
@abhisheksunil2201 abhisheksunil2201 deleted the test/change-theme branch June 24, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright 💎 Bounty A bounty on Algora.io Low priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

4 participants