Skip to content

fix: copy icon for dark mode#9459

Merged
keithwillcode merged 2 commits into
calcom:mainfrom
Veer0x1:copy-icon
Jun 12, 2023
Merged

fix: copy icon for dark mode#9459
keithwillcode merged 2 commits into
calcom:mainfrom
Veer0x1:copy-icon

Conversation

@Veer0x1
Copy link
Copy Markdown
Contributor

@Veer0x1 Veer0x1 commented Jun 11, 2023

What does this PR do?

Fixes the visibility of copy icon in dark mode

Fixes #9458

Screenshot 2023-06-12 at 12 02 55 AM

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 11, 2023

@Veer0x1 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 8:28am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 12, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/installed/[category] 277.39 KB 428.36 KB 122.39% (🟡 +0.19%)
/getting-started/[[...step]] 425.58 KB 576.54 KB 164.73% (🟡 +0.22%)
/new-booker/[user]/[type] 393.95 KB 544.92 KB 155.69% (🟡 +0.16%)
/new-booker/d/[link]/[slug] 393.95 KB 544.92 KB 155.69% (🟡 +0.16%)
/new-booker/team/[slug]/[type] 393.96 KB 544.92 KB 155.69% (🟡 +0.16%)
/settings/my-account/calendars 252.09 KB 403.06 KB 115.16% (🟡 +0.23%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@Udit-takkar Udit-takkar changed the title fixed copy icon for dark mode fix: copy icon for dark mode Jun 12, 2023
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I pushed some changes

@keithwillcode keithwillcode added this pull request to the merge queue Jun 12, 2023
Merged via the queue into calcom:main with commit 75e638e Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Copy icon is not visible in dark mode

4 participants