Skip to content

feat: verificationTokenComponent#9476

Merged
PeerRich merged 2 commits into
calcom:mainfrom
saurabbot:feat--vtComponent
Jul 1, 2023
Merged

feat: verificationTokenComponent#9476
PeerRich merged 2 commits into
calcom:mainfrom
saurabbot:feat--vtComponent

Conversation

@saurabbot
Copy link
Copy Markdown
Contributor

@saurabbot saurabbot commented Jun 12, 2023

What does this PR do?

Fixes #9468

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Jul 1, 2023 6:35pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 12, 2023

@saurabbot is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the ✨ feature New feature or request label Jun 12, 2023
@saurabbot saurabbot changed the title component made feat: verificationTokenComponent Jun 12, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 12, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@saurabbot
Copy link
Copy Markdown
Contributor Author

saurabbot commented Jun 13, 2023

@sean-brydon could you have a look, not sure about stories code.

@PeerRich PeerRich requested a review from a team June 17, 2023 16:33
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jun 17, 2023

cc @sean-brydon

@PeerRich PeerRich requested a review from sean-brydon June 17, 2023 16:33
@sean-brydon
Copy link
Copy Markdown
Member

sean-brydon commented Jun 29, 2023

Sorry missed this in my notifications! Code looks create just testing it!

sean-brydon
sean-brydon previously requested changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't push to your branch but we can improve the types here to work getter with the library we use for pin inputs.

CleanShot 2023-06-29 at 09.08.19@2x.png

Nice work!

@PeerRich PeerRich requested a review from sean-brydon July 1, 2023 18:30
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jul 1, 2023

I can't push to your branch but we can improve the types here to work getter with the library we use for pin inputs.

CleanShot 2023-06-29 at 09.08.19@2x.png

Nice work!

lets address this in a follow up PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2023

Thank you for following the naming conventions! 🙏

@PeerRich PeerRich enabled auto-merge (squash) July 1, 2023 18:30
@PeerRich PeerRich dismissed sean-brydon’s stale review July 1, 2023 18:30

lets do this in a follow up PR

@PeerRich PeerRich merged commit 4bea5a0 into calcom:main Jul 1, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@saurabbot @PeerRich @fritterhoff
feat: verificationTokenComponent (calcom#9476)
dbbf801 
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees

No one assigned

Labels

✨ feature New feature or request

Projects

No open projects
Reviewing PRs
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-1932] Create DIGIT input a component

3 participants

@saurabbot @PeerRich @sean-brydon