fix: Routing form two "New" button issue.#9479
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Nikeshkumar-tk is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Nikeshkumar-tk
changed the title
Udit-takkar
approved these changes
Jun 13, 2023
| <ShellMain | ||
| heading="Routing Forms" | ||
| CTA={hasPaidPlan && <NewFormButton />} | ||
| CTA={hasPaidPlan && forms?.length && <NewFormButton />} |
Member
There was a problem hiding this comment.
@Nikeshkumar-tk It sets CTA to literal 0, when there are no forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9478
Type of change
Bug fix (non-breaking change which fixes an issue)
Verify wheather there is a New button in shell when routing forms are empty.
Mandatory Tasks
Checklist