feat: weekly view calendar improvements#9491
Conversation
CAL-1918 Week view - base start/end time on event schedule
The start and end time props in Lets say you have the following availability schedule for the event: In that case we want to get 9am and 9pm as start and end time respectively. That way we know for sure if we set this as bounds of the calendar, everything will be visible in view. I tried to query the schedule from the event type (or with a separate db query), but somehow I kept getting 1970 as the start and end dates. I guess it's just me, but couldn't find out what I was doing wrong. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Ninety-six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 98 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/15/2023 09:59:17am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f348dd5 Started: 06/15/2023 09:57:33am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Can delete user account
Retry 2 • Retry 1 • Initial Attempt |
1.20% (3)3 / 250 runsfailed over last 7 days |
28.40% (71)71 / 250 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- old-booker can add multiple organizer address
Retry 1 • Initial Attempt |
0.83% (2)2 / 240 runsfailed over last 7 days |
15.42% (37)37 / 240 runsflaked over last 7 days |
…nt time and events in correct timezone
JeroenReumkens
changed the title
Thanks for the review @Udit-takkar! This has been fixed now. Could you please retest it? 😁 |
|
@JeroenReumkens Still not fixed now it shows 5:00PM 
|
Hmmm interesting. So there's an additional 30 min offset for you. Let me check again. |
…mt x.5 timezones that are offset 30 mins.
There was a problem hiding this comment.
@JeroenReumkens found some issues in multi duration
when i select 15min then the size of blocks feels 30minutes ( 9:30 - 10:00) and when i change the duration to 90min the empty block size is just half an hour
…ation in multi duration event
Amazing find!! Just pushed a fix for this too. It should now adapt to the option you choose! |
* Add correct start/end time for weekly calendar by looking at calendar's availability * Always show 24h in weekly calendar, added scroll functionality, current time and events in correct timezone * Improved current time style * Show slots for every minute, so also odd timeslots due to offsets work * Show correct timeformat for weekly view on left side time stamps * Fix data attr for debug * Position events differently so we can accomodate for offset start times. * Removed schedule from public event api, because we don't use it anymore * Fixed alignment of timeslots in weekview calendar. * Added loading spinner to weekly calendar * Force weekly view calendar hour labels to show 00 minutes, also for gmt x.5 timezones that are offset 30 mins. * Change event duration blocks in weekly calendar when user changes duration in multi duration event * Improved week view slot time label alignments for shorter durations --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
4 participants
What does this PR do?
Fixes CAL-1918
CleanShot.2023-06-14.at.20.09.43.mp4
Type of change
How should this be tested?