fix: redirect to 404 page for invalid email verification token

[iamr-kumar]

What does this PR do?

Fixes #9469

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Send email verification link. Copy paste the link in browser and modify the token.
• Go to /api/auth/verify-email?token={some-invalid-token}

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

[vercel]

@iamr-kumar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	❌ Failed (Inspect)			Jun 19, 2023 9:00am

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[Udit-takkar]

well this is what is see when i enter incorrect token in param. The text says username /404 does not exist

we should display correct text here like "Your token has expired".
you can check /pages/404 page to see how you can show custom message based on condition

[iamr-kumar]

Thanks for the input. Also could you help me with how to get the strings translated? Or is it done by the maintainers?

[iamr-kumar]

Updated the 404 page

[Udit-takkar]

Thanks for the input. Also could you help me with how to get the strings translated? Or is it done by the maintainers?

You just have to create string in english common/en.json file and use it like t("page_does_not_exist") in the code.

[iamr-kumar]

Thanks for the input. Also could you help me with how to get the strings translated? Or is it done by the maintainers?

You just have to create string in english common/en.json file and use it like t("page_does_not_exist") in the code.

My point was if the translation to other languages is automated or not. But thanks anyway. I didn't need to create any new string as found some existing ones that fit the use case :)

[Udit-takkar]

LGTM. works fine

[sean-brydon]

thank you! Nice work

[zomars]

@sean-brydon @Udit-takkar this is causing other 404 pages to show as invalid token when it's not the case. Will revert this PR.

[iamr-kumar]

@zomars could you specify which pages (or pattern) are getting affected, as isInvalidToken should only be true when intentionally redirecting to 404, which I don't see being done from anywhere else.