Skip to content

fix: Email verification banner#9519

Merged
hariombalhara merged 1 commit into
mainfrom
fix/email-banner
Jun 15, 2023
Merged

fix: Email verification banner#9519
hariombalhara merged 1 commit into
mainfrom
fix/email-banner

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #9518

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 5:48pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 5:48pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 5:48pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 5:48pm

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/installed/[category] 276.72 KB 427.65 KB 122.19% (🟢 -0.21%)
/event-types 426.56 KB 577.5 KB 165.00% (🟢 -0.15%)
/getting-started/[[...step]] 424.82 KB 575.75 KB 164.50% (🟢 -0.23%)
/new-booker/[user]/[type] 393.44 KB 544.37 KB 155.53% (🟢 -0.24%)
/new-booker/d/[link]/[slug] 393.43 KB 544.37 KB 155.53% (🟢 -0.23%)
/new-booker/team/[slug]/[type] 393.44 KB 544.37 KB 155.53% (🟢 -0.24%)
/settings/my-account/calendars 251.31 KB 402.24 KB 114.93% (🟢 -0.24%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/14/2023 05:46:24pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cdd96a0

Started: 06/14/2023 05:44:54pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- new-booker can add multiple organizer address
Retry 1Initial Attempt
3.60% (10) 10 / 278 runs
failed over last 7 days
20.86% (58) 58 / 278 runs
flaked over last 7 days

View Detailed Build Results


@Udit-takkar Udit-takkar changed the title fix: add isLoading in condition fix: Email verification banner Jun 15, 2023
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hariombalhara hariombalhara merged commit 3116d6d into main Jun 15, 2023
@hariombalhara hariombalhara deleted the fix/email-banner branch June 15, 2023 06:11
iamr-kumar pushed a commit to iamr-kumar/cal.com that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1948] Seeing email verification banner in loading state

2 participants