fix: routing-forms protected with LicenseRequired by Meetcpatel · Pull Request #9521 · calcom/cal.diy

Meetcpatel · 2023-06-14T18:03:11Z

What does this PR do?

This PR protect
/apps/routing-forms/forms
/apps/routing-forms/form-edit
/apps/routing-forms/route-builder
/apps/routing-forms/reporting
with LicenseRequired

Fixes #9480

Loom Video: https://www.loom.com/share/62643aa0db6049c892db0d92c0e6ef52?sid=2b8ac4c9-8bf3-4dd9-bfa0-70a370ed631b

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Test A
- visit /apps/routing-forms/forms, /apps/routing-forms/form-edit, /apps/routing-forms/route-builder, /apps/routing-forms/reporting

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

(all completed)

vercel · 2023-06-14T18:03:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	❌ Failed (Inspect)			Jul 6, 2023 5:22pm

vercel · 2023-06-14T18:03:18Z

@Meetcpatel is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2023-06-14T18:12:22Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

PeerRich · 2023-06-17T16:31:19Z

hey @Meetcpatel can you look into the merge conflict? 🙏 @hariombalhara will then review and merge!

Meetcpatel · 2023-06-18T04:21:47Z

hey @Meetcpatel can you look into the merge conflict? 🙏 @hariombalhara will then review and merge!

Done! Fixed conflict.

hariombalhara · 2023-06-23T13:31:27Z

-                      if (!form) {
-                        return null;
-                      }
+    <LicenseRequired>


SingleForm is used by form-edit, reporting, route-builder. So, we can add LicenseRequired there itself and we won't need to duplicate this everywhere.

reverted LicenseRequired from routing-forms/pages/forms

I am not sure why you reverted /forms. I wanted you to revert form-edit, reporting, route-builder because all of them use a common wrapper component SingleForm which we can wrap in LicenseRequired. It would automatically add LicenseRequired to form-edit, reporting and route-builder

I see SingleForm used only with form-edit, reporting, and route-builder so wrapping SingleForm in LicenseRequired works for all three routes.

and /forms should be wrapped in LicenseRequired right?

@hariombalhara

Yeah exatly.

hariombalhara

Thankyou @Meetcpatel. I left some comments.

github-actions · 2023-06-23T13:53:02Z

Thank you for following the naming conventions! 🙏

try again please

hariombalhara

Requesting changes again.

github-actions · 2023-07-22T00:17:48Z

This PR is being marked as stale due to inactivity.

hariombalhara

LGTM now !! Thanks @Meetcpatel 🙏

routing-forms protected with LicenseRequired

baff42e

github-actions Bot added ✅ good first issue Good for newcomers 🐛 bug Something isn't working labels Jun 14, 2023

Meetcpatel changed the title ~~routing-forms protected with LicenseRequired~~ fix: routing-forms protected with LicenseRequired Jun 14, 2023

vercel Bot deployed to Preview – ui June 14, 2023 18:07 View deployment

Meetcpatel closed this Jun 14, 2023

Meetcpatel reopened this Jun 14, 2023

CarinaWolli requested a review from a team June 16, 2023 06:40

PeerRich added the Low priority Created by Linear-GitHub Sync label Jun 17, 2023

merged

ecf1f19

vercel Bot had a problem deploying to Preview – ui June 18, 2023 04:25 Failure

hariombalhara reviewed Jun 23, 2023

View reviewed changes

Comment thread yarn.lock

hariombalhara reviewed Jun 23, 2023

View reviewed changes

Comment thread packages/app-store/routing-forms/pages/reporting/[...appPages].tsx Outdated

hariombalhara reviewed Jun 23, 2023

View reviewed changes

hariombalhara previously requested changes Jun 23, 2023

View reviewed changes

Delete yarn.lock

83fe2bc

vercel Bot had a problem deploying to Preview – ui June 23, 2023 13:56 Failure

Meetcpatel added 2 commits June 23, 2023 20:15

LicenseRequired added

3803ffd

merged

33e46dc

Meetcpatel marked this pull request as draft June 23, 2023 14:52

Meetcpatel added 3 commits June 24, 2023 09:58

fixed

4d813e0

fixed

255c2b8

Merge branch 'main' into routing-forms-protected

823efaa

vercel Bot deployed to Preview – ui June 24, 2023 04:37 View deployment

vercel Bot deployed to Preview – ui June 24, 2023 04:41 View deployment

fixed

5088dda

vercel Bot deployed to Preview – ui June 24, 2023 05:09 View deployment

Meetcpatel marked this pull request as ready for review June 24, 2023 05:11

PeerRich requested review from a team and hariombalhara June 25, 2023 15:12

hariombalhara requested changes Jul 6, 2023

View reviewed changes

Meetcpatel added 2 commits July 6, 2023 22:44

SingleForm wraped with LicenseRequired

2d3f50c

Merge branch 'main' into routing-forms-protected

62c709d

vercel Bot had a problem deploying to Preview – ui July 6, 2023 17:22 Failure

github-actions Bot added the Stale label Jul 22, 2023

hariombalhara self-requested a review July 24, 2023 14:13

hariombalhara approved these changes Jul 24, 2023

View reviewed changes

hariombalhara merged commit 41850c7 into calcom:main Jul 24, 2023

fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023

fix: routing-forms protected with LicenseRequired (calcom#9521)

cdd16c3

Conversation

Meetcpatel commented Jun 14, 2023

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel Bot commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jun 14, 2023

Uh oh!

github-actions Bot commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

PeerRich commented Jun 17, 2023

Uh oh!

Meetcpatel commented Jun 18, 2023

Uh oh!

Uh oh!

Uh oh!

hariombalhara Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

Meetcpatel Jun 24, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

Meetcpatel Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 22, 2023

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Jun 14, 2023 •

edited

Loading

github-actions Bot commented Jun 14, 2023 •

edited

Loading

github-actions Bot commented Jun 23, 2023 •

edited

Loading

hariombalhara left a comment •

edited

Loading