Skip to content

fix: check user session in banner#9530

Merged
sean-brydon merged 1 commit into
mainfrom
fix/disable-email-banner-on-public-pages
Jun 15, 2023
Merged

fix: check user session in banner#9530
sean-brydon merged 1 commit into
mainfrom
fix/disable-email-banner-on-public-pages

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes Follow up on #9519

Screenshot 2023-06-15 at 11 46 36 AM
  • now hides email verification banner when user is not logged in

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Jun 15, 2023 6:38am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 6:38am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 6:38am
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 6:38am

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 15, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/15/2023 06:30:03am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cd89570

Started: 06/15/2023 06:28:04am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- new-booker can add multiple organizer address
Retry 1Initial Attempt
2.61% (6) 6 / 230 runs
failed over last 7 days
22.61% (52) 52 / 230 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it <3

@sean-brydon sean-brydon merged commit e513180 into main Jun 15, 2023
@sean-brydon sean-brydon deleted the fix/disable-email-banner-on-public-pages branch June 15, 2023 08:36
iamr-kumar pushed a commit to iamr-kumar/cal.com that referenced this pull request Jun 18, 2023
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants