feat: Enable new booker globally for 3.0#9541
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/15/2023 04:35:45pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 58891c8 Started: 06/15/2023 04:33:16pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
6.18% (16)16 / 259 runsfailed over last 7 days |
27.03% (70)70 / 259 runsflaked over last 7 days |
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests -- new-booker Paid rescheduling should go to success page
Retry 1 • Initial Attempt |
1.21% (3)3 / 247 runsfailed over last 7 days |
1.21% (3)3 / 247 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 146 runsfailed over last 7 days |
10.27% (15)15 / 146 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
5.12% (13)13 / 254 runsfailed over last 7 days |
20.47% (52)52 / 254 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
6.45% (10)10 / 155 runsfailed over last 7 days |
93.55% (145)145 / 155 runsflaked over last 7 days |
PeerRich
approved these changes
Jun 15, 2023
hariombalhara
changed the title
hariombalhara
approved these changes
Jun 15, 2023
zomars
reviewed
Jun 15, 2023
…ure_flag/migration.sql
iamr-kumar
pushed a commit
to iamr-kumar/cal.com
that referenced
this pull request
Jun 18, 2023
* Update migration to be on by default - remove cookie check * Use env variable to control enabling NEW_BOOKER for all * Update packages/prisma/migrations/20230524105015_added_newbooker_feature_flag/migration.sql * Update turbo.json --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Omar López <zomars@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
NEW_BOOKER_ENABLED_FOR_EMBED=1